Skip to content

[fix] Fixed docker images unecessary prefetching from hub #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

filipecosta90
Copy link
Contributor

Fixes #41

@filipecosta90 filipecosta90 added bug Something isn't working tool-builder Tooling changes: Benchmark artifacts builder labels Aug 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #44 (f60042b) into main (e2d3bdf) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   69.48%   69.79%   +0.30%     
==========================================
  Files          12       12              
  Lines         626      629       +3     
==========================================
+ Hits          435      439       +4     
+ Misses        191      190       -1     
Impacted Files Coverage Δ
...is_benchmarks_specification/__builder__/builder.py 73.37% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d3bdf...f60042b. Read the comment docs.

@filipecosta90 filipecosta90 merged commit 11f11a8 into main Aug 23, 2021
@filipecosta90 filipecosta90 deleted the builder.docker.fixes branch August 23, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool-builder Tooling changes: Benchmark artifacts builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis-benchmarks-spec builder 0.1.10 keeps pulling docker when all images are local
2 participants