fix socket error handlers #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
- Coverage 95.25% 94.79% -0.46%
==========================================
Files 387 387
Lines 3517 3496 -21
Branches 423 414 -9
==========================================
- Hits 3350 3314 -36
- Misses 83 105 +22
+ Partials 84 77 -7
Continue to review full report at Codecov.
|
|
Thanks for fixing this, guys! Any plans to release this soon in a new version? |
Contributor
Author
|
@a-koka 4.1.0 will be released in a few days |
|
Thanks a lot for the fix! :) |
This was referenced Aug 1, 2022
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
* fix socket error handlers, reset parser on error * fix redis#2080 - reset pubSubState on socket error * fix pubsub * fix "RedisSocketInitiator"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2080, potentially fix #2058, #2032, #1985