Add getCodec method to StatefulConnection #3444
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a getCodec() method to StatefulRedisClusterConnectionImpl to provide access to the underlying Redis codec, bringing consistency with StatefulRedisConnectionImpl which already has this method.
- Add public
getCodec()method that returns theRedisCodec<K,V>instance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/io/lettuce/core/cluster/StatefulRedisClusterConnectionImpl.java
Show resolved
Hide resolved
mdellison90-stack
approved these changes
Sep 17, 2025
|
Hey @jruaux , can you give me some context to why we need this? Overall I am not opposed, but I'd rather expose it as part of the contract, as right now it requires casting which is not a very good pattern to follow. |
jruaux
changed the title
|
@tishun Good point. I added |
a-TODO-rov
approved these changes
Oct 9, 2025
|
LGTM |
a-TODO-rov
added a commit
that referenced
this pull request
Oct 14, 2025
a-TODO-rov
added a commit
that referenced
this pull request
Oct 14, 2025
a-TODO-rov
added a commit
that referenced
this pull request
Oct 20, 2025
a-TODO-rov
added a commit
that referenced
this pull request
Oct 20, 2025
This reverts commit bcabe0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
RedisCodec<K,V> getCodec()method likeStatefulRedisConnectionImpldoes