Skip to content

reuse-objectmapper-defaultjsonparser #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

reuse-objectmapper-defaultjsonparser #3372

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b285ae3
reuse-objectmapper-defaultjsonparser
thachlp Jul 24, 2025
34b563b
Allow injection of custom ObjectMapper in DefaultJsonParser
thachlp Aug 4, 2025
713a5d2
Add JavaDoc
tishun Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/main/java/io/lettuce/core/json/DefaultJsonParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,27 @@
*/
public class DefaultJsonParser implements JsonParser {

private final ObjectMapper objectMapper;

/**
* Create a new instance of the {@link DefaultJsonParser} initialing a {@link ObjectMapper} with defaults.
*/
public DefaultJsonParser() {
objectMapper = new ObjectMapper();
}

/**
* Create a new instance of the {@link DefaultJsonParser} using the provided {@link ObjectMapper}.
*
* @param objectMapper the {@link ObjectMapper} to use
*/
public DefaultJsonParser(ObjectMapper objectMapper) {
if (objectMapper == null) {
throw new IllegalArgumentException("ObjectMapper must not be null");
}
this.objectMapper = objectMapper;
}

@Override
public JsonValue loadJsonValue(ByteBuffer bytes) {
return new UnproccessedJsonValue(bytes, this);
Expand Down Expand Up @@ -52,7 +73,6 @@ public JsonArray createJsonArray() {

@Override
public JsonValue fromObject(Object object) {
ObjectMapper objectMapper = new ObjectMapper();
try {
JsonNode root = objectMapper.valueToTree(object);
return DelegateJsonValue.wrap(root);
Expand All @@ -66,9 +86,8 @@ private JsonValue parse(String value) {
return DelegateJsonValue.wrap(NullNode.getInstance());
}

ObjectMapper mapper = new ObjectMapper();
try {
JsonNode root = mapper.readTree(value);
JsonNode root = objectMapper.readTree(value);
return DelegateJsonValue.wrap(root);
} catch (JsonProcessingException e) {
throw new RedisJsonException(
Expand All @@ -81,11 +100,10 @@ private JsonValue parse(ByteBuffer byteBuffer) {
return DelegateJsonValue.wrap(NullNode.getInstance());
}

ObjectMapper mapper = new ObjectMapper();
try {
byte[] bytes = new byte[byteBuffer.remaining()];
byteBuffer.get(bytes);
JsonNode root = mapper.readTree(bytes);
JsonNode root = objectMapper.readTree(bytes);
return DelegateJsonValue.wrap(root);
} catch (IOException e) {
throw new RedisJsonException("Failed to process the provided value as JSON", e);
Expand Down