RediSearch with Lettuce - final fixes #3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishun
changed the title
This was referenced Jul 22, 2025
Docs part (to squash later) Modified CreateArgs and SearchArgs Address review comments 1/many Addressed review comment by Igor, more polishing
tishun
force-pushed
the
topic/tishu/redisearch-polishing
branch
from
c6d31ec to
b83d851
Compare
tishun
added a commit
that referenced
this pull request
Aug 7, 2025
* RediSearch support (part 1 of 3) (#3325) * Revert "Revert "Add support for FT.CREATE #2717 (#3150)" (#3160)" (#3161) This reverts commit 319e315. * Add support for FT.DROPINDEX #2722 (#3164) * Add support for FT.DROPINDEX #2722 * Polishing * FT.SEARCH added Vibe code the FT.SEARCH command Pulled latest from the integration branch Fixed a lot of the hallucinations RESP2 parser improvements JSON Indexing tests Add some advanced use-cases Fixed all integration tests Fixed schema fields, added vector tests, but they are all failing Fixed vector search tests Improve coverage of integration and unit tests One unit test fails * API cleanup, added Kotlin implementation * Implement the FT.AGGREGATE command Fixing the integration tests for FT.AGGREGATE Polishing 1/3 Add more documentation ot the AggregateArgs * Implement the FT.CURSOR command Add Integration tests for the FT.CURSOR Add RESP2 tests for all aggragation integration tests * FT.AGGREGATE was never working in the first place, now it is working, but for RESP3 only * Fixing unit tests (part1) Fixing unit tests (part2) Fixing unit tests (part3) * Polishing (part 1) * RediSearch support (part 2 of 3) (#3360) Introducing the FT.ALTER Introducing the FT.ALIASADD, FT.ALIASUPDATE, FT.ALIASDEL Introducing the FT.TAGVALS * RediSearch support (part 3 of 3) (#3364) * Introducing the FT.SUGADD FT.SUGDEL FT.SUGGET and FT.SUGLEN * Introducing the FT.DICTADD, FT.DICTDEL, FT.DICTDUMP * Introducing the FT.SPELLCHECK * Introducing the FT.SPELLCHECK (polishing) * Introducing the FT.EXPLAIN, FT.SYNUPDATE, FT.SYNDUMP, FT._LIST * Introducing the FT.PROFILE Polishing 1 Polishing 1 * Polishing 2 * Removing the FT.PROFILE command entirely * Polishing 3 * Polishing 4 * RediSearch with Lettuce - final fixes (#3371) * Fix wrong aggregation arguments order Docs part (to squash later) Modified CreateArgs and SearchArgs Address review comments 1/many Addressed review comment by Igor, more polishing * Cluster tests * Extend wordlist * Extend wordlist 2 * Avoid NPE when empty result received * Avoid NPE when empty result received 2 * Disable cluster tests for 7.2 and 7.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide basic support for RediSearch as part of #2746
Includes:
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.