Allowed connect to redis-master with ssl. #2024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
reviewed
Jul 17, 2019
gkorland
reviewed
Jul 17, 2019
keddar1
changed the title
sazzad16
suggested changes
Jul 20, 2019
| @@ -35,6 +35,11 @@ | |||
| this(host, port, connectionTimeout, soTimeout, password, database, clientName, | |||
| false, null, null, null); | |||
| } | |||
| JedisFactory(final String host, final int port, final int connectionTimeout, | |||
| final int soTimeout, final String password, final int database, final String clientName, final boolean isRedisSslEnabled) { | |||
There was a problem hiding this comment.
Do we need this constructor? Isn't following constructor enough?
I'm asking this because JedisFactory is kept to have fewest constructors.
| public class JedisSentinelPool extends JedisPoolAbstract { | ||
|
|
||
| protected GenericObjectPoolConfig poolConfig; | ||
|
|
||
| protected int connectionTimeout = Protocol.DEFAULT_TIMEOUT; | ||
| protected int soTimeout = Protocol.DEFAULT_TIMEOUT; | ||
|
|
There was a problem hiding this comment.
An empty line would make code more readable.
|
I think we should have a test for this use case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use redis-server with sentinel I can not use safe connect to redis-server with ssl because sentinel Pool in default create not safe connection.