Copy client hooks to child connections. #2680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2023 16:24
When creating a new connection from a client, uses the parent hooks as a base, to ensure mocking is consistent.
Fixes the Redis Gears TFunctionList test, which was flapping due to an undefined order of functions being returned.
|
Hey @Crystalix007 can you check the implementation that is part of #3320 . I think it covers your usecase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables parent hooks on child connections to allow mocking to hook into the commands run on those connections.
Also fixes a flapping test on Redis Gears, caused by an assumption in the order of returned functions.