Avoid CLIENT SETNAME command when using HELLO

[filipecosta90]

The following PR allows for more control of the protocol version ( avoiding errors when we know beforehand what will be the supported protocol version ) and the removal of the extra CLIENT SETNAME <string> command when we use HELLO in a successful manner.
If no ProtocolVersion is specified we default to 3. RESP3 has certain advantages since when the connection is in this mode, Redis is able to reply with more semantical replies.

[ash2k]

Hi! I wonder if this will solve the problem I described here #2537? Thanks.

[monkey92t]

I don't quite understand what problem this PR is meant to solve.

[monkey92t]

I suggest adding a hook to address the related issue. If the user sets a custom initialization function, we can use it instead of the default connection initialization method.

[chayim]

IMHO you can send this either way, and no need for the if check:

127.0.0.1:6379> hello 3 setname foo
1# "server" => "redis"
2# "version" => "6.2.12"
3# "proto" => (integer) 3
4# "id" => (integer) 4
5# "mode" => "standalone"
6# "role" => "master"
7# "modules" => (empty array)
127.0.0.1:6379> hello 3 setname ""
1# "server" => "redis"
2# "version" => "6.2.12"
3# "proto" => (integer) 3
4# "id" => (integer) 4
5# "mode" => "standalone"
6# "role" => "master"
7# "modules" => (empty array)
127.0.0.1:6379> 

WDYT @filipecosta90

[ndyakov]

Closing this stale PR.