RI-7461: Unable to edit string key in JSON formatter #4977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ConfirmationPopover is "outside" the click detector "jurisdiction", clicking anywhere on it unmounts the editor and therefore, form submission does not happen
pd-redis
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
valkirilov
as code owners
valkirilov
approved these changes
Sep 23, 2025
Code Coverage - Frontend unit tests
Test suite run success5150 tests passing in 677 suites. Report generated by 🧪jest coverage report action from ea97457 |
KrumTy
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable outside click detector when ConfirmationPopover is shown.
Since ConfirmationPopover is "outside" the click detector "jurisdiction",
clicking anywhere on it unmounts the editor and therefore, \form submission does not happen