[RI-7280] resolve redux store circular dependencies during tests #4809
+94
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # redisinsight/ui/src/components/connectivity-error/ConnectivityError.tsx # redisinsight/ui/src/components/inline-item-editor/InlineItemEditor.tsx # redisinsight/ui/src/components/item-list/components/delete-action/DeleteAction.tsx # redisinsight/ui/src/components/item-list/components/export-action/ExportAction.tsx # redisinsight/ui/src/components/query/query-actions/QueryActions.tsx # redisinsight/ui/src/components/query/query-card/QueryCardHeader/QueryCardHeader.tsx # redisinsight/ui/src/components/side-panels/panels/enablement-area/EnablementArea/components/InternalPage/InternalPage.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyHash/AddKeyHash.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyList/AddKeyList.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyReJSON/AddKeyReJSON.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeySet/AddKeySet.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyStream/AddKeyStream.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyString/AddKeyString.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyZset/AddKeyZset.tsx # redisinsight/ui/src/pages/browser/modules/key-details/components/rejson-details/components/edit-entire-item-action/EditEntireItemAction.tsx # redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/add-set-members/AddSetMembers.tsx # redisinsight/ui/src/pages/database-analysis/components/header/Header.tsx # redisinsight/ui/src/pages/home/components/database-list-header/DatabaseListHeader.tsx # redisinsight/ui/src/pages/home/components/database-manage-tags-modal/ManageTagsModal.tsx # redisinsight/ui/src/pages/settings/components/cloud-settings/CloudSettings.tsx # redisinsight/ui/src/pages/settings/components/cloud-settings/components/user-api-keys-table/UserApiKeysTable.tsx # redisinsight/ui/src/pages/slow-log/components/Actions/Actions.tsx
KrumTy
requested review from
dantovska,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
Code Coverage - Integration Tests
|
Code Coverage - Backend unit tests
Test suite run success2940 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 82adae0 |
Code Coverage - Frontend unit tests
Test suite run success4826 tests passing in 634 suites. Report generated by 🧪jest coverage report action from 82adae0 |
valkirilov
previously approved these changes
Aug 6, 2025
valkirilov
previously approved these changes
Aug 6, 2025
| csrf: cloneDeep(initialStateAppCsrfReducer), | ||
| init: cloneDeep(initialStateAppInit), | ||
| connectivity: cloneDeep(initialStateAppConnectivity), | ||
| dbSettings: cloneDeep(initialStateAppDbSettings), |
There was a problem hiding this comment.
Yeah, I forgot that this one was missing. Kudos for resolving it 👌
KrumTy
changed the title
valkirilov
previously approved these changes
Aug 6, 2025
pawelangelow
previously approved these changes
Aug 6, 2025
KrumTy
dismissed stale reviews from pawelangelow and valkirilov
The base branch was changed.
…rcular-dependencies
pd-redis
approved these changes
Aug 6, 2025
valkirilov
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: In jest ui unit tests we use configureMockStore instead of the real Redux store. The mock store doesn't actually use the reducers - it just holds state. However, when the test runs, some component or hook is trying to access the actual Redux store configuration, which expects the reducers to be properly defined. Hence we get a lot of errors in the console, that usually happen after a test finishes successfully.
Solution: Use redux store wrapper during unit tests that avoids circular dependencies via dynamic import.
A better solution would require large refactor of the code base.