Skip to content

Wrong argument count in VectorField #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Wrong argument count in VectorField #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NRedisStack/Search/Schema.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ internal override void AddFieldTypeArgs(List<object> args)
args.Add(Algorithm.ToString());
if (Attributes != null)
{
args.Add(Attributes.Count());
args.Add(Attributes.Count() * 2);

foreach (var attribute in Attributes)
{
Expand Down
36 changes: 35 additions & 1 deletion tests/NRedisStack.Tests/Search/SearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,7 @@ public void TestFieldsCommandBuilder()
"vec",
"VECTOR",
"FLAT",
"1",
"2",
"dim",
"10"
};
Expand Down Expand Up @@ -1876,6 +1876,40 @@ public async Task Test_ListAsync()
Assert.Equal(await ft._ListAsync(), new RedisResult[] { });
}

[Fact]
public async Task TestVectorCount_Issue70()
{
var schema = new Schema().AddVectorField("fieldTest", Schema.VectorField.VectorAlgo.HNSW, new Dictionary<string, object>()
{
["TYPE"] = "FLOAT32",
["DIM"] = "128",
["DISTANCE_METRIC"] = "COSINE"
});

var actual = SearchCommandBuilder.Create("test", new FTCreateParams(), schema);
var expected = new List<object>()
{
"test",
"SCHEMA",
"fieldTest",
"VECTOR",
"HNSW",
"6",
"TYPE",
"FLOAT32",
"DIM",
"128",
"DISTANCE_METRIC",
"COSINE"
};
Assert.Equal("FT.CREATE", actual.Command);
for (int i = 0; i < actual.Args.Length; i++)
{
Assert.Equal(expected[i].ToString(), actual.Args[i].ToString());
}
Assert.Equal(expected.Count(), actual.Args.Length);
}

[Fact]
public void TestModulePrefixs1()
{
Expand Down