Creating CommandBuilders #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shacharPash
force-pushed
the
SupportTransactions
branch
from
5df838e to
f1ebf4e
Compare
shacharPash
changed the title
slorello89
reviewed
Nov 21, 2022
…to SupportTransactions
Contributor
|
@shacharPash I think this PR should include changes to the sparse README. It's time to show users how they can use this. |
chayim
reviewed
Nov 29, 2022
| namespace NRedisStack | ||
| { | ||
|
|
||
| public static class BloomCommandBuilder |
Contributor
There was a problem hiding this comment.
IMHO comment the class too. Let's explain to users why this exists, why it's an issue.
Contributor
|
@leibale I asked Shachar to document.. anything else from your side? From a logic/impl perspective it looks sane to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.