Skip to content

Time-series insertion filters that allow ignoring close-by samples #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 5, 2024
Merged

Time-series insertion filters that allow ignoring close-by samples #303

merged 14 commits into from
Jun 5, 2024

Conversation

@atakavci
Copy link
Collaborator

@atakavci atakavci commented May 28, 2024 •
edited
Loading

Closes/Fixes #302

  • added parameter builders for CREATE, ALTER, ADD, INCRBY, DECRBY
  • added IGNORE option for set of commands
  • added unit tests
  • marked old commands(ones with multiple individual parameters) as obsolete and aiming to drop them with a major version release in future

thanks to @gerzse for comments and feedbacks on builder classes and method signatures

@atakavci atakavci requested review from gerzse and uglide May 28, 2024 07:39
@atakavci atakavci self-assigned this Jun 3, 2024
uglide
uglide approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atakavci atakavci merged commit 2d5babb into redis:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uglide uglide uglide approved these changes

@gerzse gerzse Awaiting requested review from gerzse

Assignees

@atakavci atakavci

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TimeSeries - Insertion-filter for close samples

2 participants

@atakavci @uglide