Skip to content

Conversation

@RickyLin
Copy link
Contributor

@RickyLin RickyLin commented Dec 8, 2023

Closed #222

@RickyLin RickyLin closed this Dec 8, 2023
@RickyLin RickyLin reopened this Dec 8, 2023
@RickyLin RickyLin force-pushed the json-set-with-option branch 2 times, most recently from be26bc6 to 9f2b62b Compare December 8, 2023 08:19
@RickyLin RickyLin force-pushed the json-set-with-option branch from 9f2b62b to c1a91b1 Compare December 8, 2023 08:40
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a17dfe) 94.12% compared to head (efcb477) 94.12%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          85       85           
  Lines        5178     5178           
  Branches      488      488           
=======================================
  Hits         4874     4874           
  Misses        177      177           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash
Copy link
Contributor

@RickyLin Thanks for your contributing!
I see that there are some failed tests, do you want to fix it?

@RickyLin
Copy link
Contributor Author

Hi @shacharPash,
Those tests were passed after you reverted the Birthday field. I can add a comment on that field to explain why it's a field other than a propery if you think necessary.

@RickyLin
Copy link
Contributor Author

Hi @shacharPash,
I'm not very familar with the process, I saw this "All checks have passed" message in this PR, did you mean there are other failed tests besides tests under this "All checks have passed"?
image

@shacharPash
Copy link
Contributor

Hi @shacharPash, Those tests were passed after you reverted the Birthday field. I can add a comment on that field to explain why it's a field other than a propery if you think necessary.

@RickyLin You're right, I should have refreshed the page 😅

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash merged commit f6a251f into redis:master Dec 11, 2023
@RickyLin RickyLin deleted the json-set-with-option branch December 12, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have more JSON serialization controls on JsonCommands Set methods.

3 participants