Introduce procedure mode selection for RedisGraph.

[haysch]

Problem

It is not possible to use GraphCache for replicas-only connections.
If GraphCache.GetCachedData is invoked, the following exception will be thrown

StackExchange.Redis.RedisServerException: READONLY You can't write against a read only replica.
   at NRedisStack.Auxiliary.ExecuteAsync(IDatabaseAsync db, SerializedCommand command)
   at NRedisStack.GraphCommandsAsync.QueryAsync(String graphName, String query, Nullable`1 timeout)
   at NRedisStack.GraphCommandsAsync.CallProcedureAsync(String graphName, String procedure, IEnumerable`1 args, Dictionary`2 kwargs)
   at NRedisStack.GraphCommandsAsync.CallProcedureAsync(String graphName, String procedure)

Context

Current implementation uses Query and QueryAsync for every CALL PROCEDURE.
However, as procedures can be defined as write or read (as defined by dbms.procedures()), it would make sense to be able to select mode.

Solution

Add option to specify procedures as Read or Write when calling CallProcedure and CallProcedureAsync.

Discussion

I opted to go for the enum approach, and specify ProcedureMode.Write as default to avoid breaking existing use.
One could instead go with a new CallReadProcedure and CallReadProcedureAsync.

[codecov-commenter]

Codecov Report

Patch coverage: 96.96% and project coverage change: +0.17% 🎉

Comparison is base (78be574) 93.82% compared to head (08238a8) 93.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   93.82%   93.99%   +0.17%     
==========================================
  Files          82       82              
  Lines        5082     5080       -2     
  Branches      476      479       +3     
==========================================
+ Hits         4768     4775       +7     
+ Misses        185      177       -8     
+ Partials      129      128       -1     

Files Changed	Coverage Δ
src/NRedisStack/Graph/GraphCacheList.cs	97.36% <94.73%> (-2.64%)	⬇️
src/NRedisStack/Graph/GraphCommands.cs	94.44% <100.00%> (+7.30%)	⬆️
src/NRedisStack/Graph/GraphCommandsAsync.cs	94.44% <100.00%> (+7.30%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shacharPash]

Hi @haysch, thanks for your contribution!
I hope to go through the PR in the coming days.
In the meantime, I noticed that the coverage has dropped a bit, can you fix it?

[haysch]

Sure thing, will look into it as soon as possible.

Please let me know what you think of the procedure mode discriminator.
As stated I was a bit in doubt what would fit best - an enum or a new method.

[shacharPash]

Hi, thanks again for your contribution, looks good!
I wrote some comments and questions about the code. I would appreciate it if you could answer my questions and change what is needed :)

[haysch]

First batch of answers.
Will take a look at the remaining suggestions later :)

[haysch]

Is it possible to retry the test run without pushing a dummy commit?
It seems like something had gone wrong in a completely unrelated test 🤔

[shacharPash]

@slorello89 do you want to take a look?

[shacharPash]

LGTM 👍