Draft: Replace bypass BufferedIO when IO#timeout is available
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby IOs have an internal buffer already, the only reason we have to buffer again ourselves is to be able to timeout on `IO#gets`. With `IO#timeout` being introduced in Ruby 3.2, we can get rid of the second buffer. This is just a PoC, there is a handful of test failures, I just wanted to explore.
|
This OpenSSL limitation was fixed: ruby/openssl#714 Not sure when I'll get back to this, but we should have a path forward now. |
|
It’s awesome to see this is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby IOs have an internal buffer already, the only reason we have to buffer again ourselves is to be able to timeout on
IO#gets.With
IO#timeoutbeing introduced in Ruby 3.2, we can get rid of the second buffer.This is just a PoC, there is a handful of test failures, I just wanted to explore.
FYI: @ioquatix
One discovered issue is that we can't do that with
SSLSocket: ruby/openssl#693, to be explored further.