Extended compare and run-remote tool #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Fixed massive variance blocking regression detection - Added proper variance-based validation that prevents false positives when latency data is too unstable for reliable analysis • Fixed missing test links in performance summaries - Corrected regression counting logic so clickable Grafana links appear in bullet lists for confirmed regressions • Added conditional AWS credentials checking - Credentials are only required when actually needed (for infrastructure deployment or S3 upload, not when using existing infrastructure with --inventory) • Added automatic tool installation - Missing dependencies like redis-server, zip, and memtier_benchmark are automatically installed on remote nodes using official Redis APT repository • Enhanced S3 upload error handling - Upload failures don't crash the process but continue with warnings, ensuring benchmark results are preserved locally even when S3 is unavailable These changes make run-remote much more robust, user-friendly, and reliable by eliminating false regression alerts, providing better diagnostic information, reducing setup requirements, and gracefully handling common failure scenarios.
… are store in timeseries. fixed tox-docker deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixed massive variance blocking regression detection - Added proper variance-based validation that prevents false positives when latency data is too unstable for reliable analysis
• Fixed missing test links in performance summaries - Corrected regression counting logic so clickable Grafana links appear in bullet lists for confirmed regressions
• Added conditional AWS credentials checking - Credentials are only required when actually needed (for infrastructure deployment or S3 upload, not when using existing infrastructure with --inventory)
• Added automatic tool installation - Missing dependencies like redis-server, zip, and memtier_benchmark are automatically installed on remote nodes using official Redis APT repository
• Enhanced S3 upload error handling - Upload failures don't crash the process but continue with warnings, ensuring benchmark results are preserved locally even when S3 is unavailable