Skip to content

Enable SSUBSCRIBE benchmark mode #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Enable SSUBSCRIBE benchmark mode #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b0e4a
Using go-redis for SSUBSCRIBE benchmark mode
filipecosta90 Apr 29, 2023
79f1d5b
Using go > 1.18 for testing due to go-redis
filipecosta90 Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
test:
strategy:
matrix:
go-version: [1.17.x, 1.18.x, 1.19.x, 1.20.x]
go-version: [1.18.x, 1.19.x, 1.20.x]
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
6 changes: 0 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ cd $GOPATH/src/github.com/redis-performance/pubsub-sub-bench
make
```

#### Limitations

There are know limitations on old go version due to the radix/v3 dependency, given that on old versions,
the go command in GOPATH mode does not distinguish between major versions, meaning that it will look for the package `package github.com/mediocregopher/radix/v3` instead of v3 of `package github.com/mediocregopher/radix`.
Therefore you should only use this tool on go >= 1.11.

## Usage of pubsub-sub-bench

```
Expand Down
9 changes: 7 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ module github.com/RedisLabs/pubsub-sub-bench
go 1.13

require (
github.com/golangci/golangci-lint v1.50.1 // indirect
github.com/mediocregopher/radix/v3 v3.5.2
github.com/kr/text v0.2.0 // indirect
github.com/mediocregopher/radix/v4 v4.1.2
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
github.com/redis/go-redis/v9 v9.0.3
github.com/stretchr/testify v1.8.0 // indirect
gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f // indirect
)

replace github.com/redis/go-redis/v9 => github.com/filipecosta90/go-redis/v9 v9.0.0-20230429203646-959c94037c1e
Loading