Add command to add JDK to settings #4162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
rgrunber
reviewed
Sep 26, 2025
There was a problem hiding this comment.
Seems mostly fine. Just be aware this overlaps with https://github.com/microsoft/vscode-java-pack/blob/main/src/java-runtime/index.ts and it probably would have been ideal to move that page here.
| canSelectMany: false, | ||
| title: 'Select JDK Directory', | ||
| }); | ||
| if (directory) { |
There was a problem hiding this comment.
Is it worth validating the directory by at least checking ${directory}/bin/javac exists to ensure it's probably a valid JDK ?
|
|
||
| export namespace JavaRuntimes { | ||
| export async function initialize(context: vscode.ExtensionContext): Promise<void> { | ||
| context.subscriptions.push(vscode.commands.registerCommand('java.runtimes.add', async () => { |
There was a problem hiding this comment.
I'd probably add "java.runtimes.add" to Commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a VS Code command that