add a java mp jpa scenario using crunchy psql operator #631
Conversation
|
Hi @ajm01. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thank you very much, Andrew, let me do a review :) |
|
/ok-to-test |
ajm01
force-pushed
the
new-jpa-scenario
branch
3 times, most recently
from
54dc1d4 to
5badd43
Compare
|
Hi @sbose78 - i think I have covered all comments, if you want to look this over again. I have the referenced app src code updated to include a CRUD gui and it is merged into our sample repo now. |
| uid: e3ca87f2-0208-4b00-82bb-db4345f834dd | ||
| finalizers: | ||
| - finalizer.servicebindingrequest.openshift.io | ||
| spec: |
There was a problem hiding this comment.
@Avni-Sharma Would that be a validation of master or are the changes available on operatorhub ?
There was a problem hiding this comment.
Validation of master and beta channel where we have the changes in 0.2.0-387 on operator-hub
There was a problem hiding this comment.
Also , all the examples/ in the repo have the new APIs now
ajm01
force-pushed
the
new-jpa-scenario
branch
2 times, most recently
from
40dc554 to
63f2383
Compare
|
@ajm01: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test 4.5-acceptance |
| ```shell | ||
| kubectl get secret jpa-pgcluster-my-demo-db | ||
| NAME TYPE DATA AGE | ||
| jpa-pgcluster-my-demo-db Opaque 5 13m |
There was a problem hiding this comment.
Could you print the contents of the secret please?
|
@ajm01 can you rework this PR to match the current API please? |
|
@pedjak I think now, we need a rework for the API and annotations as well |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ajm01
force-pushed
the
new-jpa-scenario
branch
2 times, most recently
from
1b894df to
7c7ccd3
Compare
ajm01
force-pushed
the
new-jpa-scenario
branch
from
7c7ccd3 to
3e448e5
Compare
|
closing this PR for now due to its use of odo and the downlevel SBO. Will work to understand if the sample can be re-written to avoid the use of odo and make use of the latest updates to SBO and its annotation updates. |
6 participants
fixes #611
Motivation
Introduce a new sample scenario - java openliberty microservice jpa app using a CrunchyData PostgreSQL Operator managed db and the Service Binding Operator. Also shows the use of odo to create the SBR, the intermediate secret object and how to configure the CruncyData PostgreSQL CR.
Changes
added a readme document describing the process from start to finish.
Testing
n/a at this stage
For further more details refer the CONTRIBUTING.md