CARRY: Update go build to v1.21 #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold Just holding it until 2.9 is officially release so it does not end up in it by accident. |
|
Otherwise LGTM :) |
|
/unhold |
|
@VanillaSpoon is it good to go now? |
|
I think this needs some changes after @dgrove-oss changes. It should be enough to just change the GOLANG_IMAGE to be an approved image |
|
Closing as done: #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link: here
There are currently no UBI 8 images available that support Go 1.21, which will be required to merge: project-codeflare#541
A similar issue was previously addressed in cpass where a workaround was implemented