Skip to content

Conversation

Bensuo
Copy link
Collaborator

@Bensuo Bensuo commented May 24, 2023

  • Add support for USM memcpy and copy in graphs
  • New MemoryManager method for usm copies
  • New PI extension methods for enqueueing USM copies
  • Re-enabled and fixed issues in E2E tests for copies
  • Minor changes to queue_impl to capture copies correctly

Closes #147

- Add support for USM memcpy and copy in graphs
- New MemoryManager method for usm copies
- New PI extension methods for enqueueing USM copies
- Re-enabled and fixed issues in E2E tests for copies
- Minor changes to queue_impl to capture copies correctly
@Bensuo Bensuo added the Graph Implementation Related to DPC++ implementation and testing label May 24, 2023
@Bensuo Bensuo requested review from EwanC, reble and julianmi May 24, 2023 14:47
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addittion

Copy link
Owner

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, updated symbols are in #187
couldn't suggest those changes here, because the files are not in this PR.

@Bensuo Bensuo merged commit 583fb91 into sycl-graph-develop May 26, 2023
@Bensuo Bensuo deleted the ben/usm-memcpy branch August 7, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement using handler USM memory copies in a graph node.
3 participants