EA: use adaptive-css feature for light/dark model
#635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let EA to handle light/dark mode. We keep updating the internal variable `documentationThemeMode` just in case we need it in the future for now. We can remove it eventually if we want. Requires readthedocs/ethical-ad-client#229
|
The adaptive light/dark mode is available on the beta client and I'll aim to roll it out more widely in a couple days. Based on this code, it looks like your plan is to always set the placement as adaptive and then it will adapt if the theme supports it. That should be OK in virtually all cases. |
Yes. I will start there relying completely con the EA CSS. We can make adjustments (enable/disable this) for specific themes/doctools in the near future if we find that it doesn't work as expected. It worked in all the themes I tried, so far. |
ericholscher
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let EA to handle light/dark mode. We keep updating the internal variable
documentationThemeModejust in case we need it in the future for now. We can remove it eventually if we want.Requires readthedocs/ethical-ad-client#229