Use footer text content ad for unknown themes #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is much less intrusive than the stickybox, and allows us to still have an ad injected, but not cover the content for users when this happens.
davidfischer
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Looks good. My only worry is in the rare case where none of the selectors match and we just append the ad to <body> but that probably won't happen.
Line 400 in 57d34df
humitos
approved these changes
Mar 14, 2025
|
This looks great! I tested it locally and I found only two doctools where it doesn't work great, but they seem to be special cases and we can adapt/fix them later in another PR. I think we can merge it and deploy it tomorrow. Pelican
Sphinx Awesome theme
|
|
Yea, I think we can adjust it a bit as we see how it works, and also of course just not add the ad if we fallback to |
ericholscher
pushed a commit
that referenced
this pull request
Jun 24, 2025
Alternates between using the stickybox placement and the footer placement on unknown themes. It also adds an ID to the stickybox placement so we can see performance of it. As written, this introduces a random element which may not be desirable. We could instead introduce the stickybox only on very wide screens (say >=1600px) or we could base it on the title of the project or something like that to make it deterministic. I'm open to suggestions. > // TODO: Check this placement on the dashboard, > // and see how this is performing. The footer placement is performing very well at ~4x the CTR with ~50% the view rate vs. previously. Ref: #562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much less intrusive than the stickybox,
and allows us to still have an ad injected,
but not cover the content for users when this happens.
Replaces #447
Closes #311