Use ContextRoot at document.html instead #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
force-pushed
the
agj/lit-context-config
branch
from
dbb7494 to
4ada43e
Compare
humitos
approved these changes
Jan 16, 2025
Member
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
Thanks for putting an example for this. I will merge this PR into mine now and continue from there.
humitos
pushed a commit
that referenced
this pull request
Jan 22, 2025
Additional elements shouldn't be needed in our structure. This is how we can use ContextRoot with `document.html` as the context root for providers/consumers of the config context.
humitos
pushed a commit
that referenced
this pull request
Jan 22, 2025
Additional elements shouldn't be needed in our structure. This is how we can use ContextRoot with `document.html` as the context root for providers/consumers of the config context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional elements shouldn't be needed in our structure. This is how we can use ContextRoot with
document.htmlas the context root for providers/consumers of the config context.Both the flyout and the notifications load for me with this change.