Notifications: don't go to top page when closing it #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When clicking on the X, now it calls `preventDefault()` to avoid moving to the top * I added some `id=` attributes in the index page to test this manually Closes #246
agjohnson
approved these changes
Feb 14, 2024
Contributor
agjohnson
left a comment
agjohnson
left a comment
There was a problem hiding this comment.
This makes sense. I assume this is because the link has a href="#" or similar, so this is a good way to avoid the default behavior here.
Member
Author
Yes (https://github.com/readthedocs/readthedocs-client/blob/07e519e11143d399052c216ae831c012d516c209/src/notification.js#L212). Should we remove it? |
Contributor
|
I would say it's fine as is, your fix does solve the problem. In places where we need to worry about users with JS disabled, it's best to make this a valid URL. But obviously we don't have that problem with Addons. |
… humitos/close-notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preventDefault()to avoid moving to the topid=attributes in the index page to test this manuallyCloses #246