Skip to content

fix: improve unhighlightable contents check #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+6 −2
Open

fix: improve unhighlightable contents check #170

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0097de
fix: improve unhighlightable contents check
tefkah Nov 9, 2025
7b3c9a6
fix: restore accidental edit
tefkah Nov 9, 2025
e96d53f
fix: actually include the fix
tefkah Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions navigator-html-injectables/src/modules/Decorator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,12 @@ class DecorationGroup {
// The common ancestor is an element that definitely cannot be highlighted
this.notTextFlag?.set(id, true);
}
if(ancestor.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {
// Contains elements that definitely cannot be highlighted as children
// Check if the range itself contains elements that cannot be highlighted
const rangeFragment = range.cloneContents();
const tempDiv = this.wnd.document.createElement('div');
tempDiv.appendChild(rangeFragment);
if(tempDiv.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {
// Range contains elements that definitely cannot be highlighted
this.notTextFlag?.set(id, true);
}
if((ancestor.textContent?.trim() || "").length === 0) {
Expand Down