Skip to content

Allow async onCreatePublication callbacks #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow async onCreatePublication callbacks #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Shared/Publication/Publication.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public class Publication: Closeable, Loggable {
_ manifest: inout Manifest,
_ container: inout Container,
_ services: inout PublicationServicesBuilder
) -> Void
) async -> Void

private var manifest: Manifest
private var container: Container
Expand All @@ -185,12 +185,12 @@ public class Publication: Closeable, Loggable {
self.servicesBuilder = servicesBuilder
}

public mutating func apply(_ transform: Transform?) {
public mutating func apply(_ transform: Transform?) async {
guard let transform = transform else {
return
}

transform(&manifest, &container, &servicesBuilder)
await transform(&manifest, &container, &servicesBuilder)
}

/// Builds the `Publication` from its parts.
Expand Down
2 changes: 1 addition & 1 deletion Sources/Streamer/PublicationOpener.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public class PublicationOpener {
switch await parser.parse(asset: asset, warnings: warnings) {
case var .success(builder):
for transform in builderTransforms {
builder.apply(transform)
await builder.apply(transform)
}
return .success(builder.build())

Expand Down