About screen sui #492
Merged
About screen sui #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| Image(systemName: iconName) | ||
| } | ||
| .font(.title2) | ||
| .foregroundColor(Color(red: 0.0, green: 0.18, blue: 0.39)) |
There was a problem hiding this comment.
You should avoid using custom colors as they won't work well with iOS upgrades or the dark mode (That includes .foregroundColor(.gray)).
There was a problem hiding this comment.
yeah, thanks, fix it
Comment on lines
41
to
43
| .background(Color(UIColor.secondarySystemGroupedBackground)) | ||
| .cornerRadius(10) | ||
| .shadow(radius: 2) |
There was a problem hiding this comment.
You can use a GroupBox to get a similar look but native to the platform.
There was a problem hiding this comment.
yeah, thanks, fix it
Comment on lines
+101
to
+104
| private extension URL { | ||
| static let edrlab = URL(string: "https://www.edrlab.org/")! | ||
| static let license = URL(string: "https://opensource.org/licenses/BSD-3-Clause")! | ||
| } |
|
fix iPad layout |
|
fix iPad layout |
|
@mickael-menu I think I fix all issues, can you check this MR one more time plz? |
mickael-menu
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate about screen with SwiftUI and make it more stylish :)