Update HTTPServer API
#424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettore
approved these changes
May 15, 2024
| /// Callbacks handling a request. | ||
| /// | ||
| /// If the resource cannot be served, the `onFailure` callback is called. | ||
| public struct HTTPRequestHandler { |
There was a problem hiding this comment.
nit: not that important but I was wondering why this struct and HTTPServerRequest are not in their own files, since they are public types.
There was a problem hiding this comment.
I like to keep tightly related types in the same file. If HTTPServer was a struct or class instead of a protocol, I would have used HTTPServer.Request.
|
Thanks for reviewing @ettore 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Shared
HTTPServerslightly changed to be more future-proof.HTTPServerAPI.