-
Notifications
You must be signed in to change notification settings - Fork 178
Initial pass at Locator.Locations.time
#382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should I also remove the private extension on |
mickael-menu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @domkm!
The enum is great. Could you add some documentation for the public APIs, maybe linking to the spec? https://www.w3.org/TR/media-frags/#media-fragment-syntax
You can also remove the private extension and use the new one instead.
Thanks again.
|
Ha forgot to ask, could you rebase it to |
|
When adding that doc string, I realized that my names are not aligned with the W3 doc that you sent. They use |
|
Yes I think that would be best to stick to the standard when possible 👍 |
|
👍 |
mickael-menu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes @domkm!
Implements #372.
@mickael-menu I went with an enum instead of a struct but I can alter it if you wish. Thanks!