Prevent multiple OutlineFragment instances on repeated menu clicks. #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ReaderActivity.kt.
|
Thank you @janiceferns02. Could you address the formatting issue? You can run |
|
@mickael-menu I have resolved the formatting issue. Am I still missing something? |
mickael-menu
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where multiple OutlineFragment instances are added when the menu item is clicked repeatedly in quick succession in the ReaderActivity.
Fix: Before adding OutlineFragment, we now check if it already exists in the FragmentManager using findFragmentByTag.
Tested by repeatedly tapping the ≡ menu icon multiple times very quickly and confirmed that only a single instance of OutlineFragment is ever created.