-
Couldn't load subscription status.
- Fork 115
fix(tts): add missing supported timeline command to TtsSessionAdapter #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
without this command the session-adapter didn't properly report the current timeline to a media3.MediaSession
|
What is timeline used for? |
|
If using the ForwardingSimpleBasePlayer to modify MediaSession, it has a |
|
I understand that. But what does this getState do better with the timeline? I'm not entirely sure my timeline implementation is good or useful in the adapter, that's why I ask. |
|
Without a timeline the SimpleBasePlayer dies on an assert that timeline must not be empty if the player is not in IDLE state. For us this crashes the entire MediaSession when we call Exception: As long as SimpleBasePlayer sees a non-empty timeline, everything seems to work. I guess this only happens, since we wrap the |
|
Ok, I see. If you want a specific notification button layout, you might expect a better timeline than my shitty one. Are you expecting resource-based navigation in the notification? I might have not exposed it because of the notification actually, I need to check. |
|
As far as I understand and remember the missing timeline command is more of a feature than a bug. To prevent your crash you should be able to provide a timeline by yourself by overriding |
|
@qnga turns out I have to completely duplicate/re-implement the entire So basically I have to copy their implementation but leave out this non-empty playlist assert and the check on Maybe the TtsSessionAdapter should just report a single item on the playlist when active? |

without this command the session-adapter didn't properly report the current timeline to a media3.MediaSession