EXC_BAD_ACCESS when running within an ARC project

[vdaubry]

Hi,

On the master branch :

I manage to run the readium SDK inside a non-arc project without any problem.

I tried running it inside a ARC enabled project, i add a -fno-objc-arc flag to all the readium classes but it crashes in RDPackage when opening an epub :

RDPackage.mm:149

ArchiveReader* ReaderForRelativePath(const string& path) const { return _archive->ReaderAtPath((_pathBase + path).stl_str()); }

Do you have any idea how i can run the ReadiumSDK inside a ARC enabled project ?

Thanks,
Vincent

[vdaubry]

Here is a sample project that reproduces this crash :

https://github.com/vdaubry/readium-arc

[vdaubry]

Actually it seems the crash occurs when the RDContainer is released. I managed to avoir the crash by retaining it.

I don't understand why we should retain the container since the SpineItemController already retains the RDPackage

Is that the intended behavior ?

[AlanQuatermain]

Probably because in the C++ API the Package objects are owned by their respective Containers.

Sent from my iPhone

On 2013-04-26, at 3:49 AM, vdaubry notifications@github.com wrote:

Actually it seems the crash occurs when the RDContainer is released. I managed to avoir the crash by retaining it.

I don't understand why we should retain the container since the SpineItemController already retains the RDPackage

Is that the intended behavior ?

�
Reply to this email directly or view it on GitHub.

[agilshane]

Well, the short answer is that the iOS launcher app is not an ARC project. If parts of the launcher app are copied into an ARC-based project, all retain/release logic will need to be reviewed and adapted as necessary.

[youboox]

I migrated the project to ARC inb this pull request : #7

[rkwright]

Readium was migrated to ARC long ago. Closing as resolved.