Highlight does not work

[sajjadrad]

Hi
I cloned develop branch and used highlight api,but nothing happens.
getCurrentSelectionCfi function returns null,addSelectionHighlight do nothing after select a text.
I used this code in a button click event:

    NSString *result = [m_webView stringByEvaluatingJavaScriptFromString:@"ReadiumSDK.reader.getCurrentSelectionCfi()"];
    NSLog(@"cfi=%@",result);
    [m_webView stringByEvaluatingJavaScriptFromString:@"ReadiumSDK.reader.addSelectionHighlight(124, \"highlight\")"];

[dmitrym0]

hey @sajjadrad, did you select any text? Were there any errors in the console?

[sajjadrad]

yeah,I draged on screen and after selecting text I clicked on custom highlight button,but nothing happens.
Also there is no message on console.The log value is null too.
Thanks

[dmitrym0]

Did you look at the xcode console or javascript console?

Did you set the annotations css url (see https://github.com/readium/readium-js-viewer/blob/develop/lib/EpubReader.js#L305 and line 318 further down).

[sajjadrad]

I looked up for error in xcode console and javascript console (by safari developer).
There is no submodule with name readium-js-viewer in SDKLauncher-iOS.Is that required?Where?

[dmitrym0]

Where is the Readium instantiated in the SDK Launcher? It needs to be passed an options hash that specifies where the annotations css is.

[sajjadrad]

Do you means readium-sdk? Like develop branch it lives in root of SDK Launcher project.in resource folder I have readium-shared-js folder for js reader.also I searched for annotations css,I cant find that.

[sajjadrad]

As I understand the readium is highlighting but there is no css style file,so It wont show the yellow highlight.Is it true?

[dmitrym0]

Looks like the CSS for highlights is not specified. The second parameter into Readium initializer needs to include hash which points to the css file. Right now, when you generate a highlight, it's not visible because CSS is not specified.

[danielweck]

I actually just recently fixed the "online cloud reader" configuration, which was causing huge page load delays because of the annotation.css HTTP 404:

readium/readium-js-viewer@a9fe543

[dmitrym0]

Thanks Daniel.. I remember leaving it in a different state, where the CSS wasn't specified..

[NinhNT]

Hi all, i have the same issue and i can't see css file anywhere. Please help me find the way to fix it.Thanks!