Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.

Conversation

@bormind
Copy link

@bormind bormind commented Apr 22, 2014

Return Content-Type image/svg+xml explicitly form HTTPDataResponse and PackageResourceResponse for svg files

@rkwright
Copy link
Contributor

This was resolved long ago. Closing

@rkwright rkwright closed this Sep 21, 2014
@danielweck
Copy link
Member

@rkwright this was actually never merged into launcher-OSX, only "ported" (and improved, actually) specifically for launcher-iOS: https://github.com/readium/SDKLauncher-iOS/pull/18/files
...baring in mind that this is now in the "shared" RDServices (readium-sdk repository):
https://github.com/readium/readium-sdk/tree/develop/Platform/Apple/RDServices
See related email discussion: https://groups.google.com/d/msg/readium-dev/3OLunjnfRh8/56_55qGcf0YJ

I am reopening this Pull Request, just to keep track of the "mime type" / "http headers" issue (not just specific to SVG). The feature branch will need to be cleaned-up as well. Eventually ; sooner rather than later ; we need to update launcher-OSX to use RDServices, so that we do not have to juggle two concurrent codebases anymore (which are now functionally-identical, but not quite in synch due to historical reasons).

@danielweck danielweck reopened this Sep 24, 2014
@danielweck
Copy link
Member

So, let us merge this Pull Request specifically for Launcher-OSX, as this fixes a serious issue (#11).

Note that Launcher-iOS has a more elegant solution in RDServices (broader mime-type coverage), as per the links in my comment above. Eventually (sooner rather than later), we should migrate SDKLauncher-OSX to RDServices.

danielweck added a commit that referenced this pull request Sep 29, 2014
…r_svg

implemented svg type passing in CocoaHTTPServer
@danielweck danielweck merged commit 7b28d94 into develop Sep 29, 2014
@danielweck danielweck deleted the feature/CocoaHTTPServer_support_for_svg branch October 18, 2014 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants