Skip to content

Revert "BufferedSink: Remove progress notifications" #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

clue
Copy link
Member

@clue clue commented May 18, 2016

Reverts #24, because it currently blocks a v0.4.4 release. In other words: This restores the behavior present in the last v0.4.3 release.

I think we all agree that we want to remove the progress notifications, however this includes a BC break and thus should target a future v0.5.0 milestone.

@WyriHaximus
Copy link
Member

LGTM, lets get v0.4.4 oiut the door :shipit:

@clue clue mentioned this pull request May 20, 2016
@jsor
Copy link
Member

jsor commented May 25, 2016

LGTM :shipit:

@clue clue added this to the v0.4.4 milestone Aug 14, 2016
@clue clue merged commit 84a1771 into reactphp:master Aug 14, 2016
@clue clue deleted the revert-24-remove-progress-from-buffered-sink branch August 14, 2016 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants