Add test group to skip integration tests relying on internet connection and apply timeouts #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Jan 19, 2018
WyriHaximus
approved these changes
Jan 19, 2018
|
Merged this as the only job we're waiting for is a mac job and that's allowed to fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite contains some tests that rely on a working internet connection and upload more than 30 MB(!) and does not apply any timeouts for this. This simple PR reduces this size to 50 KB (which exhibits the same behavior as documented in #105) and applies a timeout of 10s for each test. Additionally, we now document this in our README and give instructions on how these tests can be skipped.
Builds on top of #105
Refs reactphp/socket#146