Improve DNS error messages and cancellation forwarding after DNS lookup #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Aug 1, 2018
jsor
approved these changes
Aug 2, 2018
This was referenced Sep 23, 2018
This was referenced Oct 22, 2018
This was referenced Nov 16, 2018
clue
added a commit
to clue-labs/reactphp-redis
that referenced
this pull request
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves DNS error messages (if connector fails due to DNS lookup) and improves (fixes) cancellation forwarding after the DNS lookup. This ensures that cancelling a pending connection attempt will properly cancel the underlying TCP/IP connection attempt.
The cancellation forwarding will eventually also be addressed upstream via reactphp/promise#99, but it's currently not decided when this version will be tagged. In the meantime, this PR works around this issue and improves cancellation semantics somewhat.
Refs #168 and #169