Skip to content

Conversation

Abdulrazak-Alkl
Copy link

This PR to Support new HTTP content-type "application/json".
Currently body property in request object will contains a JSON object decoded from incoming JSON string.

@ephrin
Copy link

ephrin commented Jan 4, 2016

-1 I believe mixing in framework like "helpers" to server things is not a good idea.

@marcj
Copy link

marcj commented Apr 24, 2016

+1, this library's purpose is to marshal data from tcp to PHP objects. When a client sends a file, it converts it to a FileInfo object. When urlencoded, it converts it to php array. So, when the client sends json, this library should also convert this into a php array. The only conclusion you could make. Actually I as a React\Request object consumer don't care which content-type the client used. I want the sent data not in a raw format, but as PHP objects/arrays/scalars I can just use.

@staabm
Copy link

staabm commented Apr 24, 2016

Not sure if FileInfo is appropriate because it might require to load a file into memory which wouldnt work for big/huge files. Something streamable would be good.

@clue
Copy link
Member

clue commented Sep 13, 2016

Afaict this has been filed to build a new feature on top of the previously broken master branch. Now that #59 is in, is this still relevant?

@clue
Copy link
Member

clue commented Feb 10, 2017

Thanks for filing this PR, I can assure you we're working hard on this 👍

This PR currently targets an unstable development feature that is no longer part of the master branch, so I've just filed #105 to keep track of the underlying feature request here. Please bear with us, we'll keep this ticket updated 👍

@clue clue closed this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants