Change Request methods to be in line with PSR-7 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename getQuery() to getQueryParams() * Rename getHttpVersion() to getProtocolVersion() * Change `getHeaders()` to always return an array of string values for each header
WyriHaximus
approved these changes
Feb 15, 2017
jsor
approved these changes
Feb 15, 2017
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Request methods to be in line with PSR-7
getQuery()togetQueryParams()getHttpVersion()togetProtocolVersion()getHeaders()to always return an array of string valuesfor each header
Note that this does NOT implement the PSR-7 interfaces yet, it's merely a step towards removing differences between our interfaces and PSR-7.
Refs #28
Refs #103