Skip to content

StreamSelectLoop: Fix erroneous zero-time sleep (2) #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2017
Merged

StreamSelectLoop: Fix erroneous zero-time sleep (2) #93

merged 2 commits into from
Apr 4, 2017

Conversation

ivkalita
Copy link
Contributor

@ivkalita ivkalita commented Apr 3, 2017

Resolving #48.

jsor
jsor reviewed Apr 3, 2017
View reviewed changes
tests/StreamSelectLoopTest.php Outdated
public function testSmallTimerInterval()
{
/** @var StreamSelectLoop|\PHPUnit_Framework_MockObject_MockObject $loop */
$loop = $this->getMock(StreamSelectLoop::class, ['streamSelect']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

::class requires PHP 5.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsor, sorry, yes, just updated PR.

jsor
jsor approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@jsor jsor requested review from WyriHaximus and clue April 3, 2017 19:53
@jsor jsor added this to the v0.4.3 milestone Apr 3, 2017
WyriHaximus
WyriHaximus approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clue clue modified the milestones: v0.5.0, v0.4.3 Apr 3, 2017
clue
clue approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated! LGTM and should eventually also be cherry-picked to the v0.4.3 release branch 👍

@ivkalita
Copy link
Contributor Author

ivkalita commented Apr 4, 2017

@clue, @jsor, @WyriHaximus, thank you! :)

@jsor jsor merged commit 67d845d into reactphp:master Apr 4, 2017
This was referenced Apr 4, 2017
Closed
Closed
Merged
@jsor
Copy link
Member

jsor commented Apr 4, 2017

@clue Filed #94 to add this patch to the 0.4 branch

@clue clue added the bug label Apr 4, 2017
@clue clue mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ivkalita @jsor @WyriHaximus @clue