Remove duplicate code & make code reusable #244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Faisal50x, thanks for bringing this up 👍 The same topic came up in #164 when this code was introduced. @clue did a good job at explaining that this is the very core of the event loop, thus a critical code path. Every additional function call takes up some time and we rather want to avoid this where we can. Don't get me wrong, you're suggested changes make total sense but it's also important to look at the benefit we're gaining from this, because this is an internal adjustment and only "visible" to contributors when working on this. What do you think about this? |
|
@SimonFrings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.