Use stubs from stubs package #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Dependencies 📦
|
🏰 Composer Production Dependency changes 🏰
|
WyriHaximus
force-pushed
the
3.x-use-stubs-from-stubs-package
branch
2 times, most recently
from
4925aca to
7000e4d
Compare
Ocramius
suggested changes
Jan 10, 2025
tests/Types.php
Outdated
| $pool = Runtime::create(new EventLoopBridge()); | ||
| $runtime = Runtime::create(new EventLoopBridge()); | ||
|
|
||
| assertType('null', $runtime->run(static function (): void { |
There was a problem hiding this comment.
Exact same as:
- [3.x] Add template types infinite-pool#60 (comment)
- [2.x] Ensure void return type translates to null contracts#15 (comment)
- [2.x] Ensure void return type translates to null event-loop#63 (comment)
void is not a value, and cannot be asserted upon, while Closure(): void is, and can be asserted upon.
You cannot evaluate a void expression, then assert upon it: it has no value by definition.
You will need to change this assertion:
-assertType('null', $runtime->run(static function (): void {
+assertType('Closure(): void', fn() => $runtime->run(static function (): void {
WyriHaximus
force-pushed
the
3.x-use-stubs-from-stubs-package
branch
from
7000e4d to
ae1dc0b
Compare
WyriHaximus
force-pushed
the
3.x-use-stubs-from-stubs-package
branch
from
ae1dc0b to
36c9d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.