-
Notifications
You must be signed in to change notification settings - Fork 272
support to Expo #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
support to Expo #486
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,4 +52,4 @@ | |
| "detox", | ||
| "dtrace-provider" | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -223,4 +223,4 @@ export default function Root() { | |
| </PaperProvider> | ||
| </UpdateProvider> | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,4 @@ | |
| "appId": 27509, | ||
| "appKey": "aQz3Uc2pA7gt_prDaQ4rbWRY" | ||
| } | ||
| } | ||
| } | ||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
android/src/main/java/cn/reactnative/modules/update/ReactNativeHostHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package cn.reactnative.modules.update; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
|
|
||
| public interface ReactNativeHostHandler { | ||
| @Nullable | ||
| String getJSBundleFile(boolean useDeveloperSupport); | ||
|
|
||
| @Nullable | ||
| String getBundleAssetName(boolean useDeveloperSupport); | ||
|
|
||
| void onWillCreateReactInstance(boolean useDeveloperSupport); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
android/src/main/java/expo/modules/pushy/ExpoPushyModule.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package expo.modules.pushy | ||
|
|
||
| import expo.modules.kotlin.modules.Module | ||
| import expo.modules.kotlin.modules.ModuleDefinition | ||
|
|
||
| class ExpoPushyModule : Module() { | ||
| override fun definition() = ModuleDefinition { | ||
| Name("ExpoPushy") | ||
| } | ||
| } |
27 changes: 27 additions & 0 deletions
27
android/src/main/java/expo/modules/pushy/ExpoPushyPackage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package expo.modules.pushy; | ||
|
|
||
| import android.content.Context; | ||
| import android.util.Log; | ||
| import androidx.annotation.Nullable; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import cn.reactnative.modules.update.UpdateContext; | ||
| import expo.modules.core.interfaces.Package; | ||
| import expo.modules.core.interfaces.ReactNativeHostHandler; | ||
|
|
||
| public class ExpoPushyPackage implements Package { | ||
| @Override | ||
| public List<ReactNativeHostHandler> createReactNativeHostHandlers(Context context) { | ||
| List<ReactNativeHostHandler> handlers = new ArrayList<>(); | ||
| handlers.add(new ReactNativeHostHandler() { | ||
| @Nullable | ||
| @Override | ||
| public String getJSBundleFile(boolean useDeveloperSupport) { | ||
| return UpdateContext.getBundleUrl(context); | ||
| } | ||
| }); | ||
| return handlers; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "platforms": ["apple", "android"], | ||
| "apple": { | ||
| "modules": ["ExpoPushyModule"], | ||
| "reactDelegateHandlers": ["ExpoPushyReactDelegateHandler"], | ||
| "podspecPath":"react-native-update.podspec" | ||
| }, | ||
| "android": { | ||
| "modules": [ | ||
| "expo.modules.pushy.ExpoPushyModule" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import ExpoModulesCore | ||
|
|
||
| public class ExpoPushyModule: Module { | ||
| public func definition() -> ModuleDefinition { | ||
| Name("ExpoPushy") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import ExpoModulesCore | ||
| import react_native_update | ||
|
|
||
| public final class ExpoPushyReactDelegateHandler: ExpoReactDelegateHandler { | ||
| private weak var reactDelegate: ExpoReactDelegate? | ||
|
|
||
| public override func bundleURL(reactDelegate: ExpoReactDelegate) -> URL? { | ||
| return RCTPushy.bundleURL() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个version应该可以从package.json中读取吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expo.modules.pushy属于native代码,不应该读取package.json里面的版本号吧,这里的逻辑借鉴的是
group = 'cn.reactnative.modules.update'
version = '1.0.0'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该统一版本号,不过不是很重要,以后再说吧