Skip to content

Conversation

@gsteja2307
Copy link
Contributor

#2

@gsteja2307 gsteja2307 linked an issue May 18, 2023 that may be closed by this pull request
@gsteja2307
Copy link
Contributor Author

under progress

@gsteja2307 gsteja2307 added this to the Work in Progress milestone May 18, 2023
@github-actions
Copy link

github-actions bot commented May 18, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@g-savitha g-savitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add package-lock.json to .gitignore. Don't push it.

Also please check Glossary for terms that doesn't need to be changed #13

@gsteja2307
Copy link
Contributor Author

By committing the package-lock.json file, we are ensuring that all developers working on the project have the same dependencies and versions installed

we shouldn't add it to gitignore

@g-savitha
Copy link
Contributor

Can you make the changes today? @gsteja2307

@g-savitha g-savitha merged commit 8fc5e5a into main Jan 13, 2024
@g-savitha g-savitha deleted the 2-tutorial-tic-tac-toe branch January 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial: Tic Tac Toe

2 participants