Skip to content

Translate renderToReadableStream #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 6, 2023
Merged

Translate renderToReadableStream #670

merged 18 commits into from
May 6, 2023

Conversation

@mikelmiras
Copy link
Contributor

¡Buenas noches! Ya he acabado la traducción de la página renderToReadableStream. Si hay que modificar algo, estoy abierto a ello :)

mateoguzmana
mateoguzmana requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por la contribución @mikelmiras!

Andaba a punto de empezar la revisión del PR pero noté una inconsistencia en el diff con los espacios. Quizás es tu linter local? Sería bueno revisar eso

image

@mikelmiras
Copy link
Contributor Author

mikelmiras commented May 2, 2023 •
edited
Loading

Gracias por la contribución @mikelmiras!

Andaba a punto de empezar la revisión del PR pero noté una inconsistencia en el diff con los espacios. Quizás es tu linter local? Sería bueno revisar eso

image

Sí, me acabo de fijar que visual studio code me añade las tabulaciones automáticamente, lo soluciono y actualizo, muchas gracias! =D

@mikelmiras
Traducción renderToReadableStream.md
9d3abc4 
Arreglados los espacios en blanco
@mikelmiras
Copy link
Contributor Author

Gracias por la contribución @mikelmiras!
Andaba a punto de empezar la revisión del PR pero noté una inconsistencia en el diff con los espacios. Quizás es tu linter local? Sería bueno revisar eso
image

Sí, me acabo de fijar que visual studio code me añade las tabulaciones automáticamente, lo soluciono y actualizo, muchas gracias! =D

Ya debería estar solucionado el diff de los espacios :)

@mikelmiras mikelmiras requested a review from mateoguzmana May 3, 2023 09:35
mateoguzmana
mateoguzmana reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Todo se ve muy bien en general @mikelmiras!

Te he dejado un par de cosas para que revises.

mikelmiras and others added 9 commits May 6, 2023 15:31
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
644c8f2 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
c567653 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
3fc48e8 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
8966180 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
7a8d227 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
3e3e8a6 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
1655d73 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
d8db6ba 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras @mateoguzmana
Update src/content/reference/react-dom/server/renderToReadableStream.md
ffc68b7 
Co-authored-by: Mateo Guzmán <[email protected]>
@mikelmiras mikelmiras requested a review from mateoguzmana May 6, 2023 13:32
@mateoguzmana mateoguzmana merged commit c96c79b into reactjs:main May 6, 2023
@github-actions
Copy link

github-actions bot commented May 6, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@carburo carburo mentioned this pull request May 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mateoguzmana mateoguzmana mateoguzmana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikelmiras @mateoguzmana