Skip to content

Adding translations to the startTransition API #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 2, 2023
Merged

Adding translations to the startTransition API #631

merged 11 commits into from
Apr 2, 2023

Conversation

@RubenChirino
Copy link
Contributor

@github-actions github-actions bot added the beta label Feb 18, 2023
@carburo carburo mentioned this pull request Feb 24, 2023
Closed
carburo
carburo requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@carburo carburo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Hola! ¡Gracias por tu contribución! Te he dejado algunos comentarios antes de mezclar el PR. Todos están en forma de sugerencias de GitHub que puedes aplicar o en caso que estés en desacuerdo, puedes dejar comentar en ese mismo lugar. La mayor parte son relacionados con el uso de «usted» para la segunda persona del singular. Para mantener la consistencia en la documentación y porque es menos propenso a ambigüedades hemos optado por usar siempre «tú» (Puedes consultar nuestra guía de traducción para otros aspectos como este).

@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited
Loading

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

RubenChirino and others added 7 commits April 1, 2023 11:30
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
206e272 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
f32ca47 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
34f7a94 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
16d2922 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
a1dc13d 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
212a0ab 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino @carburo
Update beta/src/content/reference/react/startTransition.md
07a9f3f 
Co-authored-by: Rainer Martinez <[email protected]>
@RubenChirino
Copy link
Contributor Author

Gracias @carburo por las correciones, lo tendré en cuenta para las proximas! He tomado todos tus aportes.

carburo
carburo approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@carburo carburo merged commit ee0743e into reactjs:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carburo carburo carburo approved these changes

Assignees

No one assigned

Labels

beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RubenChirino @carburo