Skip to content

Fix state mismatch during component update #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fix state mismatch during component update #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/idom/core/layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,11 +216,6 @@ def _render_component(
pass
else:
key, index = new_state.key, new_state.index
if old_state is not None:
assert key == old_state.key, (
"state mismatch during component update - "
f"key {key!r}!={old_state.key!r} "
)
parent.children_by_key[key] = new_state
# need to do insertion in case where old_state is None and we're appending
parent.model.current["children"][index : index + 1] = [
Expand Down