Skip to content

reduce log spam from missing keys in children #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022
Merged

reduce log spam from missing keys in children #564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/idom/core/vdom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,11 @@ def _is_single_child(value: Any) -> bool:
)
else:
for child in value:
if (isinstance(child, ComponentType) and child.key is None) or (
isinstance(child, Mapping) and "key" not in child
):
if isinstance(child, ComponentType) and child.key is None:
logger.error(f"Key not specified for child in list {child}")
elif isinstance(child, Mapping) and "key" not in child:
# remove 'children' to reduce log spam
child_copy = {**child, "children": ...}
logger.error(f"Key not specified for child in list {child_copy}")

return False